Problem mit CWinThread oder evtl. mit dem Serial Port



  • Hi

    Bis jetzt konnte mir keiner helfen

    Ich habe eine Kassensystem Programm geschrieben in C++ MFC. Dieses Programm überwacht in einem eigenen Thread denn ComPort an dem ein Scanner angeschlossen. Alles schön und gut es funtioniert im Hauptdialog alles wunderbar. Ich intialisiere the port und starte denn Thread, welcher auf ein Ereignis wartet z.B. das der Barcode Scanner etwas gescannt hat. Das Produkt wird aus der Datenbank ausgelesen und in die ListBox eingefügt. ComPort Überwachung als Prozess wurde als eigene Klasser implementiert.

    Beim drücken der F6 wird ein Dialog aufgerufen welches mir erlauben soll ein Produkt einzuscannen welches noch nicht in der Datenbank enthalten ist.

    Bevor ich jedoch das tue beende ich denn Thread in meinem Hauptdialog und erzeuge ein neues object in meinem aufgerufen dialog welches meinem ComPort überwachen soll und intialisiere genauso wie im Hauptdialog. Jedoch funktionieren beide parallel nicht. Deaktiviere ich denn Thread vom Hauptdialog dann funktioniert der Prozess vom aufgerufenen Dialog und umgekehrt.

    Mach ich was falsch ?



  • Also ich fang mal an zu raten.

    Irgendwie klingt das so, als würdest Du versuchen zur gleichen Zeit von unterschiedlichen Orten auf die gleiche Schnittstelle zuzugreifen.
    Ich glaub nicht das das gut ist 🙄
    Wenn Du schon auf Knopfdruck das ändern willst (F6), dann solltest Du den ersten Thread erstmal sauber beenden. Mach mal nen kurzen Sleep bevor Du den zweiten Thread startest. Ich hatte es auch schon mal, das ein Thread zu schnell gestartet wurde (der erste Thread noch nicht ganz zuende war).



  • Hey ein BKI'ler ?

    post mal wengle cde dann kann man vielleicht mehr sagen, auf den ersten blick klingt es tatsache so wie Trikor sagt aber vielleicht hast du auch Probleme mit dem Port, (CreateFile ...) bissle Code wäre nützlich



  • Danke für eure Antwort.

    Bitte versucht mit zu helfen, sitze schon ein Monat an diesem Problem. Es könnte villeicht einbisschen zu viel sein. Ich versuche es trotzdem.

    Jedoch denke ich schon das ich denn Thread correct beende. Beim debuggen wird der scanner im hauptdialog und auch in dem aufzurufenden KindDialog, wo ich ein neues Produkt einfüge erkannt. Funktioniert nicht wenn ich im Run modus bin.

    Ich initialisiere denn Port InitPort() und starte denn Thread StartMonitoring() im OnInitDialog() welcher dann denn ComPort auf ein Scan Ereignis bewacht.

    // init the ports
    	if (m_Ports[0].InitPort(this, 1, 9600, 'N',8,1,EV_RXCHAR,512))
    		m_Ports[0].StartMonitoring();
    

    Methode InitPort:

    //
    // Initialize the port. This can be port 1 to 4.
    //
    BOOL CSerialPort::InitPort(CWnd* pPortOwner,	// the owner (CWnd) of the port (receives message)
    						   UINT  portnr,		// portnumber (1..4)
    						   UINT  baud,			// baudrate
    						   char  parity,		// parity 
    						   UINT  databits,		// databits 
    						   UINT  stopbits,		// stopbits 
    						   DWORD dwCommEvents,	// EV_RXCHAR, EV_CTS etc
    						   UINT  writebuffersize)	// size to the writebuffer
    {
    	assert(portnr > 0 && portnr < 5);
    	assert(pPortOwner != NULL);
    
    	// if the thread is alive: Kill
    	if (m_bThreadAlive)
    	{
    		do
    		{
    			SetEvent(m_hShutdownEvent);
    		} while (m_bThreadAlive);
    		TRACE("Thread ended\n");
    	}
    
    	// create events
    	if (m_ov.hEvent != NULL)
    		ResetEvent(m_ov.hEvent);
    	m_ov.hEvent = CreateEvent(NULL, TRUE, FALSE, NULL);
    
    	if (m_hWriteEvent != NULL)
    		ResetEvent(m_hWriteEvent);
    	m_hWriteEvent = CreateEvent(NULL, TRUE, FALSE, NULL);
    
    	if (m_hShutdownEvent != NULL)
    		ResetEvent(m_hShutdownEvent);
    	m_hShutdownEvent = CreateEvent(NULL, TRUE, FALSE, NULL);
    
    	// initialize the event objects
    	m_hEventArray[0] = m_hShutdownEvent;	// highest priority
    	m_hEventArray[1] = m_ov.hEvent;
    	m_hEventArray[2] = m_hWriteEvent;
    
    	// initialize critical section
    	InitializeCriticalSection(&m_csCommunicationSync);
    
    	// set buffersize for writing and save the owner
    	m_pOwner = pPortOwner;
    
    	if (m_szWriteBuffer != NULL)
    		delete [] m_szWriteBuffer;
    	m_szWriteBuffer = new char[writebuffersize];
    
    	m_nPortNr = portnr;
    
    	m_nWriteBufferSize = writebuffersize;
    	m_dwCommEvents = dwCommEvents;
    
    	BOOL bResult = FALSE;
    	char *szPort = new char[50];
    	char *szBaud = new char[50];
    
    	// now it critical!
    	EnterCriticalSection(&m_csCommunicationSync);
    
    	// if the port is already opened: close it
    	if (m_hComm != NULL)
    	{
    		CloseHandle(m_hComm);
    		m_hComm = NULL;
    	}
    
    	// prepare port strings
    	sprintf(szPort, "COM%d", portnr);
    	sprintf(szBaud, "baud=%d parity=%c data=%d stop=%d", baud, parity, databits, stopbits);
    
    	// get a handle to the port
    	m_hComm = CreateFile(szPort,						// communication port string (COMX)
    					     GENERIC_READ | GENERIC_WRITE,	// read/write types
    					     0,								// comm devices must be opened with exclusive access
    					     NULL,							// no security attributes
    					     OPEN_EXISTING,					// comm devices must use OPEN_EXISTING
    					     FILE_FLAG_OVERLAPPED,			// Async I/O
    					     0);							// template must be 0 for comm devices
    
    	if (m_hComm == INVALID_HANDLE_VALUE)
    	{
    		// port not found
    		delete [] szPort;
    		delete [] szBaud;
    
    		return FALSE;
    	}
    
    	// set the timeout values
    	m_CommTimeouts.ReadIntervalTimeout = 1000;
    	m_CommTimeouts.ReadTotalTimeoutMultiplier = 1000;
    	m_CommTimeouts.ReadTotalTimeoutConstant = 1000;
    	m_CommTimeouts.WriteTotalTimeoutMultiplier = 1000;
    	m_CommTimeouts.WriteTotalTimeoutConstant = 1000;
    
    	// configure
    	if (SetCommTimeouts(m_hComm, &m_CommTimeouts))
    	{						   
    		if (SetCommMask(m_hComm, dwCommEvents))
    		{
    			if (GetCommState(m_hComm, &m_dcb))
    			{
    				m_dcb.fRtsControl = RTS_CONTROL_ENABLE;		// set RTS bit high!
    				if (BuildCommDCB(szBaud, &m_dcb))
    				{
    					if (SetCommState(m_hComm, &m_dcb))
    						; // normal operation... continue
    					else
    						ProcessErrorMessage("SetCommState()");
    				}
    				else
    					ProcessErrorMessage("BuildCommDCB()");
    			}
    			else
    				ProcessErrorMessage("GetCommState()");
    		}
    		else
    			ProcessErrorMessage("SetCommMask()");
    	}
    	else
    		ProcessErrorMessage("SetCommTimeouts()");
    
    	delete [] szPort;
    	delete [] szBaud;
    
    	// flush the port
    	PurgeComm(m_hComm, PURGE_RXCLEAR | PURGE_TXCLEAR | PURGE_RXABORT | PURGE_TXABORT);
    
    	// release critical section
    	LeaveCriticalSection(&m_csCommunicationSync);
    
    	TRACE("Initialisation for communicationport %d completed.\nUse Startmonitor to communicate.\n", portnr);
    
    	return TRUE;
    }
    

    Methode StartMonitoring()

    //
    // start comm watching
    //
    BOOL CSerialPort::StartMonitoring()
    {
    
    	if (!(m_Thread = AfxBeginThread(CommThread, this)))
    		return FALSE;
    	TRACE("Thread started\n");
    	return TRUE;	
    }
    

    Jetzt kann ich Barcodes einscannen wie ich möchte, funktioniert prima. Beim drücken der F6 taste stoppe ich das Thread und schliesse das ComPort Handle und starte mein Dialog und das hab ich so gemacht

    void CKasseDlg::OnProduktverwaltungNeuesprodukteinf()
    {
    	m_Ports[0].StopMonitoring(); [u]//stop comport (Scanner) monitoring[/u]
    
    	CAddItemDlg* addItemDlg = new CAddItemDlg(this);
    	addItemDlg->DoModal();
    
    	m_Ports[0].StartMonitoring();[u] //start scanner comport monitoring
    }
    

    [/u]
    Hier die StopMonitoring Methode welches das Thread und denn ComPort schliesst:

    //
    // Suspend the comm thread
    //
    BOOL CSerialPort::StopMonitoring()
    {
    	CloseHandle(m_hComm);           [u]//schliesse bzw. gebe das ComPort wieder frei[/u]
    	m_Thread->SuspendThread();      [u]//schliesse Thread[/u]	TRACE("Thread suspended\n");
    	return TRUE;	
    }
    

    Hier die Thread Methode CommThread() die beim Start des Threads abgearbeitet wird.*

    //
    //  The CommThread Function.
    //
    UINT CSerialPort::CommThread(LPVOID pParam)
    {
    	// Cast the void pointer passed to the thread back to
    	// a pointer of CSerialPort class
    	CSerialPort *port = (CSerialPort*)pParam;
    
    	// Set the status variable in the dialog class to
    	// TRUE to indicate the thread is running.
    	port->m_bThreadAlive = TRUE;	
    
    	// Misc. variables
    	DWORD BytesTransfered = 0; 
    	DWORD Event = 0;
    	DWORD CommEvent = 0;
    	DWORD dwError = 0;
    	COMSTAT comstat;
    	BOOL  bResult = TRUE;
    
    //****Eingfügt aus Receiv Char Funktion weil comstat fehler Run Time Failure #3 Comstat gebracht hat****
    	BOOL  bRead = TRUE; 
    	DWORD BytesRead = 0;
    	unsigned char RXBuff;
    //******************************************************************************************************
    
    	// Clear comm buffers at startup
    	if (port->m_hComm)		// check if the port is opened
    		PurgeComm(port->m_hComm, PURGE_RXCLEAR | PURGE_TXCLEAR | PURGE_RXABORT | PURGE_TXABORT);
    
    	// begin forever loop.  This loop will run as long as the thread is alive.
    	for (;;) 
    	{ 
    
    		// Make a call to WaitCommEvent().  This call will return immediatly
    		// because our port was created as an async port (FILE_FLAG_OVERLAPPED
    		// and an m_OverlappedStructerlapped structure specified).  This call will cause the 
    		// m_OverlappedStructerlapped element m_OverlappedStruct.hEvent, which is part of the m_hEventArray to 
    		// be placed in a non-signeled state if there are no bytes available to be read,
    		// or to a signeled state if there are bytes available.  If this event handle 
    		// is set to the non-signeled state, it will be set to signeled when a 
    		// character arrives at the port.
    
    		// we do this for each port!
    
    		bResult = WaitCommEvent(port->m_hComm, &Event, &port->m_ov);
    
    		if (!bResult)  
    		{ 
    			// If WaitCommEvent() returns FALSE, process the last error to determin
    			// the reason..
    			switch (dwError = GetLastError()) 
    			{ 
    			case ERROR_IO_PENDING: 	
    				{ 
    					// This is a normal return value if there are no bytes
    					// to read at the port.
    					// Do nothing and continue
    					break;
    				}
    			case 87:
    				{
    					// Under Windows NT, this value is returned for some reason.
    					// I have not investigated why, but it is also a valid reply
    					// Also do nothing and continue.
    					break;
    				}
    			default:
    				{
    					// All other error codes indicate a serious error has
    					// occured.  Process this error.
    					port->ProcessErrorMessage("WaitCommEvent()");
    					break;
    				}
    			}
    		}
    		else
    		{
    			// If WaitCommEvent() returns TRUE, check to be sure there are
    			// actually bytes in the buffer to read.  
    			//
    			// If you are reading more than one byte at a time from the buffer 
    			// (which this program does not do) you will have the situation occur 
    			// where the first byte to arrive will cause the WaitForMultipleObjects() 
    			// function to stop waiting.  The WaitForMultipleObjects() function 
    			// resets the event handle in m_OverlappedStruct.hEvent to the non-signelead state
    			// as it returns.  
    			//
    			// If in the time between the reset of this event and the call to 
    			// ReadFile() more bytes arrive, the m_OverlappedStruct.hEvent handle will be set again
    			// to the signeled state. When the call to ReadFile() occurs, it will 
    			// read all of the bytes from the buffer, and the program will
    			// loop back around to WaitCommEvent().
    			// 
    			// At this point you will be in the situation where m_OverlappedStruct.hEvent is set,
    			// but there are no bytes available to read.  If you proceed and call
    			// ReadFile(), it will return immediatly due to the async port setup, but
    			// GetOverlappedResults() will not return until the next character arrives.
    			//
    			// It is not desirable for the GetOverlappedResults() function to be in 
    			// this state.  The thread shutdown event (event 0) and the WriteFile()
    			// event (Event2) will not work if the thread is blocked by GetOverlappedResults().
    			//
    			// The solution to this is to check the buffer with a call to ClearCommError().
    			// This call will reset the event handle, and if there are no bytes to read
    			// we can loop back through WaitCommEvent() again, then proceed.
    			// If there are really bytes to read, do nothing and proceed.
    
    			bResult = ClearCommError(port->m_hComm, &dwError, &comstat);
    
    			if (comstat.cbInQue == 0)
    				continue;
    		}	// end if bResult
    
    		// Main wait function.  This function will normally block the thread
    		// until one of nine events occur that require action.
    		Event = WaitForMultipleObjects(3, port->m_hEventArray, FALSE, INFINITE);
    
    		switch (Event)
    		{
    		case 0:
    			{
    				// Shutdown event.  This is event zero so it will be
    				// the higest priority and be serviced first.
    
    			 	port->m_bThreadAlive = FALSE;
    
    				// Kill this thread.  break is not needed, but makes me feel better.
    				AfxEndThread(100);
    				break;
    			}
    		case 1:	// read event
    			{
    				GetCommMask(port->m_hComm, &CommEvent);
    				if (CommEvent & EV_CTS)
    					::SendMessage(port->m_pOwner->m_hWnd, WM_COMM_CTS_DETECTED, (WPARAM) 0, (LPARAM) port->m_nPortNr);
    				if (CommEvent & EV_RXFLAG)
    					::SendMessage(port->m_pOwner->m_hWnd, WM_COMM_RXFLAG_DETECTED, (WPARAM) 0, (LPARAM) port->m_nPortNr);
    				if (CommEvent & EV_BREAK)
    					::SendMessage(port->m_pOwner->m_hWnd, WM_COMM_BREAK_DETECTED, (WPARAM) 0, (LPARAM) port->m_nPortNr);
    				if (CommEvent & EV_ERR)
    					::SendMessage(port->m_pOwner->m_hWnd, WM_COMM_ERR_DETECTED, (WPARAM) 0, (LPARAM) port->m_nPortNr);
    				if (CommEvent & EV_RING)
    					::SendMessage(port->m_pOwner->m_hWnd, WM_COMM_RING_DETECTED, (WPARAM) 0, (LPARAM) port->m_nPortNr);
    
    				if (CommEvent & EV_RXCHAR)
    					// Receive character event from port.
    					//ReceiveChar(port,comstat);   //Auskommentiert weil Fehlermeldung müsste funktionieren ka warum
    
    //****Eingfügt aus Receive Char Funktion weil comstat fehler Run Time Failure #3 Comstat gebracht hat****
    	for (;;) 
    	{ 
    		// Gain ownership of the comm port critical section.
    		// This process guarantees no other part of this program 
    		// is using the port object. 
    
    		EnterCriticalSection(&port->m_csCommunicationSync);
    
    		// ClearCommError() will update the COMSTAT structure and
    		// clear any other errors.
    
    		bResult = ClearCommError(port->m_hComm, &dwError, &comstat);
    
    		LeaveCriticalSection(&port->m_csCommunicationSync);
    
    		// start forever loop.  I use this type of loop because I
    		// do not know at runtime how many loops this will have to
    		// run. My solution is to start a forever loop and to
    		// break out of it when I have processed all of the
    		// data available.  Be careful with this approach and
    		// be sure your loop will exit.
    		// My reasons for this are not as clear in this sample 
    		// as it is in my production code, but I have found this 
    		// solutiion to be the most efficient way to do this.
    
    		if (comstat.cbInQue == 0)
    		{
    			// break out when all bytes have been read
    			break;
    		}
    
    		EnterCriticalSection(&port->m_csCommunicationSync);
    
    		if (bRead)
    		{
    			bResult = ReadFile(port->m_hComm,		// Handle to COMM port 
    							   &RXBuff,				// RX Buffer Pointer
    							   1,					// Read one byte
    							   &BytesRead,			// Stores number of bytes read
    							   &port->m_ov);		// pointer to the m_ov structure
    			// deal with the error code 
    			if (!bResult)  
    			{ 
    				switch (dwError = GetLastError()) 
    				{ 
    					case ERROR_IO_PENDING: 	
    						{ 
    							// asynchronous i/o is still in progress 
    							// Proceed on to GetOverlappedResults();
    							bRead = FALSE;
    							break;
    						}
    					default:
    						{
    							// Another error has occured.  Process this error.
    							port->ProcessErrorMessage("ReadFile()");
    							break;
    						} 
    				}
    			}
    			else
    			{
    				// ReadFile() returned complete. It is not necessary to call GetOverlappedResults()
    				bRead = TRUE;
    			}
    		}  // close if (bRead)
    
    		if (!bRead)
    		{
    			bRead = TRUE;
    			bResult = GetOverlappedResult(port->m_hComm,	// Handle to COMM port 
    										  &port->m_ov,		// Overlapped structure
    										  &BytesRead,		// Stores number of bytes read
    										  TRUE); 			// Wait flag
    
    			// deal with the error code 
    			if (!bResult)  
    			{
    				port->ProcessErrorMessage("GetOverlappedResults() in ReadFile()");
    			}	
    		}  // close if (!bRead)
    
    		LeaveCriticalSection(&port->m_csCommunicationSync);
    
    		// notify parent that a byte was received
    		::SendMessage((port->m_pOwner)->m_hWnd, WM_COMM_RXCHAR, (WPARAM) RXBuff, (LPARAM) port->m_nPortNr);
    	} // end forever loop
    
    				break;
    			}  
    		case 2: // write event
    			{
    				// Write character event from port
    				WriteChar(port);
    				break;
    			}
    
    		} // end switch
    
    	} // close forever loop
    //******************************************************************************************************
    	return 0;
    }
    

Anmelden zum Antworten